docs(planning): consolidate the carried v1.5.0 gaps — three become two - #148
Merged
Conversation
Reviewed the three items carried out of v1.5.0 rather than restating them, and two of the three moved. 21-05 TASK 5 — STRUCK AS SUPERSEDED. Phase 25 performed a genuine human pass in a live editor (25-VERIFICATION.md, 2026-08-09), and recorded itself as such precisely because this project had one checkpoint recorded the other way. It covered the toolbar and the locked-checkbox row. It did not cover the person picker or the four-group popover — so the residue is real, but it is the SAME residue as the screen-reader item, not a separate one. THE SCREEN-READER ITEM slightly WIDENED and now owns that residue. Phase 25's M2 change altered the same popover AFTER the v1.5.0 axe scan: the derived-locked checkbox went from natively disabled to aria-disabled, so a control that focus mode used to skip is now reachable and refuses its own toggle. That was the right fix — the lock reason was written for assistive technology and could never be heard while the row was skipped — but it changes tab order and announcement sequence in exactly the component that has never had a human pass, and axe passes over it either way. Both now live as one todo, with a concrete six-point script. Neither was ever a todo before; they were prose in STATE.md, which is how they survived two releases without moving. THE #128 GAP IS UNCHANGED AND VERIFIED STILL LIVE. 707d9b6 changed 192 lines of class-config.php plus the logic modules, and that mechanism is intact in main, touched since only by #138's 20-line entity-collision fix. It is the same sanitize path in which the ultrareview found four consecutive holes, and the one round no adversarial pass has seen. Closing it needs /code-review ultra over 1a32f08..707d9b6, which is user-triggered. Also struck one stale entry found while editing: the v1.5.0 milestone's "open, carried deliberately" list still said Phase 25 remains open. It shipped in v1.5.1. Struck in the same change, per the rule the 2026-08-09 reconciliation established. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewed the three items carried out of v1.5.0 rather than restating them. Two of the three moved.
21-05 Task 5 — STRUCK as superseded
Phase 25 performed a genuine human pass in a live editor (
25-VERIFICATION.md, 2026-08-09), and recorded itself as such precisely because this project had one checkpoint recorded the other way.It covered the toolbar and the locked-checkbox row. It did not cover the person picker or the four-group popover — so the residue is real, but it is the same residue as the screen-reader item, not a separate one.
The screen-reader item slightly WIDENED, and now owns that residue
Phase 25's M2 change altered the same popover after the v1.5.0 axe scan: the derived-locked checkbox went from natively
disabledtoaria-disabled, so a control that screen-reader focus mode used to skip is now reachable and refuses its own toggle.That was the right fix — the lock reason was written for assistive technology and could never be heard while the row was skipped. But it changes tab order and announcement sequence in exactly the component that has never had a human pass, and a focusable-but-refusing control is not something automated tooling can evaluate for comprehensibility. axe passes over it either way.
Both now live as one todo with a concrete six-point script. Neither was ever a todo before — they were prose in STATE.md, which is how they survived two releases without moving.
The #128 gap is unchanged, and verified still live
707d9b6changed 192 lines ofclass-config.phpplus the logic modules, and that mechanism is intact inmain, touched since only by #138's 20-line entity-collision fix.It is the same sanitize path in which the ultrareview found four consecutive holes — and the one round no adversarial pass has ever seen. Closing it needs
/code-review ultraover1a32f08..707d9b6, which is user-triggered and billed, so it isn't something I can run.Also struck: one stale entry found while editing
The v1.5.0 milestone's "open, carried deliberately" list still said Phase 25 remains open. It shipped in v1.5.1. Struck in the same change, per the rule the 2026-08-09 reconciliation established.
Risk
Planning docs only.
check:doc-linksclean.🤖 Generated with Claude Code